Re: [PATCH 03/15] powernow-k7: Work when kernel is compiled for SMP

From: Dominik Brodowski
Date: Thu Jan 05 2006 - 17:31:45 EST


On Wed, Jan 04, 2006 at 05:32:06PM -0500, Ben Collins wrote:
> On Wed, 2006-01-04 at 23:26 +0100, Dominik Brodowski wrote:
> > On Wed, Jan 04, 2006 at 04:59:31PM -0500, Ben Collins wrote:
> > > On a UP system with SMP compiled kernel, the powernow-k7 module would not
> > > initialize (returned -ENODEV). Not sure why policy->cpu != 0 for UP
> > >
> > > Signed-off-by: Ben Collins <bcollins@xxxxxxxxxx>
> >
> > May the smp_processor_id() be != 0 on _true_ UP on SMP? What happens if (using
> > virtual CPU hotplug) the module is modprobe'd with one CPU online, and then
> > the second CPU becomes online later?
>
> That's why there is num_possible_cpus() checked aswell. That's supposed
> to report possible hotplug cpu's, even if not plugged, correct?

Yes, sure. Sorry...

Dominik
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/