Re: [RFC]: add sysfs support to parport_pc, v3

From: Kay Sievers
Date: Thu Jan 05 2006 - 16:24:00 EST


On Thu, Jan 05, 2006 at 06:17:51PM +0200, Marko Kohtala wrote:
> 2006/1/5, Andrew Morton <akpm@xxxxxxxx>:
> > "Jason Dravet" <dravet@xxxxxxxxxxx> wrote:
> > > >From: Greg KH <greg@xxxxxxxxx>
> > > > > + * Added sysfs and udev - Jason Dravet <dravet@xxxxxxxxxxx>
> > > > > */
> >
> > 6 is OK - it's LP_MAJOR.
> >
> > However 99 is JSFD_MAJOR, used by drivers/sbus/char/jsflash.c. And yet my
> > /dev/parport0 is also 99:0 (RH 7.3 and RH FC1). I've no idea how that came
> > about??
> >
> > bix:/home/akpm> grep parport /etc/makedev.d/*
> > /etc/makedev.d/generic:a generic parport
> > /etc/makedev.d/linux-2.4.x:c $PRINTER 99 0 1 8 parport%d
>
> JSFD is a block device so tha majors are ok. I'm not just sure if the
> PP_MAJOR from linux/ppdev.h should be moved to major.h.
>
> The patch by Jason however is not ok. He had another problem and this
> is not the fix. What he tries to do is already in lp and ppdev, where
> I think they belong.

Yeah, I was wondering about it too.

> There is also something weird: why does RedHat create these nodes in
> /dev when udev already does that.

Probably cause they want to be safe if nothing from their sysconfig loads
the module. Opening the node will autoload it then.

Kay
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/