Re: [PATCH] drivers/media: Conversions from kmalloc+memset to kzalloc.

From: Takis
Date: Thu Jan 05 2006 - 07:38:43 EST


Hi,

2006/1/5, Pekka Enberg <penberg@xxxxxxxxxxxxxx>:
> On 1/5/06, Panagiotis Issaris <takis@xxxxxxxxxxx> wrote:
> > 993e5ce2979baa3df3d8dd238d74ea3b607e4693
> > diff --git a/drivers/media/common/saa7146_core.c b/drivers/media/common/saa7146_core.c
> > index 2899d34..38982a7 100644
> > --- a/drivers/media/common/saa7146_core.c
> > +++ b/drivers/media/common/saa7146_core.c
> > @@ -109,10 +109,9 @@ static struct scatterlist* vmalloc_to_sg
> > struct page *pg;
> > int i;
> >
> > - sglist = kmalloc(sizeof(struct scatterlist)*nr_pages, GFP_KERNEL);
> > + sglist = kzalloc(sizeof(struct scatterlist)*nr_pages, GFP_KERNEL);
>
> Hmm, these should be converted to kcalloc().
Oops... you're right. I'll send an updated patch later this evening.

With friendly regards,
Takis
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/