Re: [PATCH 04/15] i386: Handle HP laptop rebooting properly.

[Ben Collins]

On Wed, 2006-01-04 at 17:42 -0500, Kyle McMartin wrote:
> On Wed, Jan 04, 2006 at 04:59:44PM -0500, Ben Collins wrote:
> > +	{	/* HP laptops have weird reboot issues */
> > +		.callback = set_bios_reboot,
> > +		.ident = "HP Laptop",
> > +		.matches = {
> > +			DMI_MATCH(DMI_SYS_VENDOR, "Hewlett-Packard"),
> > +			DMI_MATCH(DMI_PRODUCT_NAME, "HP Compaq"),
> > +		},
> > +	},
> >  	{	/* Handle problems with rebooting on HP nc6120 */
> >  		.callback = set_bios_reboot,
> >  		.ident = "HP Compaq nc6120",
> >
> 
> Looks like the entry below could be removed, as it's now covered by
> the above.

That's correct, so here's a better trivial patch to just broaden the
existing entry.

Signed-off-by: Ben Collins <bcollins@xxxxxxxxxx>

diff --git a/arch/i386/kernel/reboot.c b/arch/i386/kernel/reboot.c
index 2afe0f8..2fa5803 100644
--- a/arch/i386/kernel/reboot.c
+++ b/arch/i386/kernel/reboot.c
@@ -111,12 +111,12 @@ static struct dmi_system_id __initdata r
 			DMI_MATCH(DMI_PRODUCT_NAME, "PowerEdge 2400"),
 		},
 	},
-	{	/* Handle problems with rebooting on HP nc6120 */
+	{	/* Handle problems with rebooting on HP laptops */
 		.callback = set_bios_reboot,
-		.ident = "HP Compaq nc6120",
+		.ident = "HP Compaq Laptop",
 		.matches = {
 			DMI_MATCH(DMI_SYS_VENDOR, "Hewlett-Packard"),
-			DMI_MATCH(DMI_PRODUCT_NAME, "HP Compaq nc6120"),
+			DMI_MATCH(DMI_PRODUCT_NAME, "HP Compaq"),
 		},
 	},
 	{ }


-- 
   Ben Collins <ben.collins@xxxxxxxxxx>
   Developer
   Ubuntu Linux

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/