Re: [PATCH] fix posix lock on NFS

[Matthew Wilcox]

On Tue, Jan 03, 2006 at 02:39:24PM -0500, Peter Staubach wrote:
> >	/* No mandatory locks over NFS */
> >-	if ((inode->i_mode & (S_ISGID | S_IXGRP)) == S_ISGID)
> >+	if ((inode->i_mode & (S_ISGID | S_IXGRP)) == S_ISGID &&
> >+	    fl->fl_type != F_UNLCK)
> 
> Just out of curiosity, what is this if() statement intended to protect?
> For locking purposes, why would the client care if the file has the
> mandatory lock bits set?

Mandatory locks aren't mandatory for other clients.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/