Re: [patch 16/19] mutex subsystem, semaphore to completion: SX8

[Ingo Molnar]

* Nick Piggin <nickpiggin@xxxxxxxxxxxx> wrote:

> Ingo Molnar wrote:
> >From: Steven Rostedt <rostedt@xxxxxxxxxxx>
> >
> >change SX8 semaphores to completions.
> >
> >Signed-off-by: Ingo Molnar <mingo@xxxxxxx>

> >+#include <linux/completion.h>
> > #include <asm/io.h>
> > #include <asm/semaphore.h>
> 
> These patches should remove the asm/semaphore.h when appropriate too.  
> At a glance, this looks like one such case.

yeah, agreed. I did this in my tree. (the other sem2completion patches 
are not affected)

> Also, these aren't really part of a mutex subsystem patch series are 
> they?

i included them because they reduce the number of semaphores that are 
used in a non-mutex fashion, and thus make the mutex conversion easier. 
I.e. i consider both the sem2mutex and the sem2completion patches as 
part of the 'convert semaphores to mutexes' effort, even though 
sem2completions are independent technically. They can be applied 
independently of the mutex subsystem itself, of course.

	Ingo
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/