Re: [patch] latency tracer, 2.6.15-rc7

[Ingo Molnar]

* Linus Torvalds <torvalds@xxxxxxxx> wrote:

> > have you applied the zlib patches too? In particular this one should 
> > make a difference:
> > 
> >     http://redhat.com/~mingo/latency-tracing-patches/patches/reduce-zlib-stack-hack.patch
> > 
> > If you didnt have this applied, could you apply it and retry with 
> > stack-footprint-debugging again?
> 
> Ingo, instead of having a static work area and using locking, why not 
> just move those fields into the "z_stream" structure, and thus make 
> them be per-stream? The z_stream structure should already be allocated 
> with kmalloc() or similar by the caller, so that also gets it off the 
> stack without the locking thing.
> 
> Hmm?

yeah, i'll implement that. The above one was just a quick hack that 
somehow survived. (and i am definitely a wimp when it comes to changing 
zlib internals :-)

	Ingo
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/