Re: [patch] updates XFS mutex patch

From: Jes Sorensen
Date: Thu Dec 29 2005 - 06:05:37 EST


>>>>> "Arjan" == Arjan van de Ven <arjan@xxxxxxxxxxxxx> writes:

Arjan> On Thu, 2005-12-29 at 05:59 -0500, Jes Sorensen wrote:
>> + +#define xfs_mutex_init(lock, type, name) mutex_init(lock)
>> +#define xfs_mutex_lock(lock, type) mutex_lock(lock) +#define
>> mutex_destroy(lock) do{}while(0)

Arjan> why not just change all mutex_init users to only pass lock?
Arjan> (same for the others) eg why add another abstraction instead of
Arjan> fixing the caller?

I have no objections to this, however I am not sure if the XFS guys
try to maintain some level of source compatibility. Just trying to
play nicely, but I agree that would be cleaner.

Cheers,
Jes
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/