Re: [PATCH] pci device ensure sysdata initialised

From: Greg KH
Date: Thu Dec 22 2005 - 18:18:20 EST


On Thu, Dec 22, 2005 at 09:06:28PM +0000, Andy Whitcroft wrote:
> pci device ensure sysdata initialised
>
> [Ok, here is a patch to ensure sysdata is valid for all busses.]
>
> We have been seeing panic's on NUMA systems in pci_call_probe() in
> 2.6.15-rc5-mm2 and -mm3. It seems that some changes have occured
> to the meaning of the 'sysdata' for a device such that it is no
> longer just an integer containing the node, it is now a structure
> containing the node and other data. However, it seems that we do not
> always initialise this sysdata before we probe the device.

Yeah, but this patch is just papering over that fact :(

In fact, you will not put these devices on the proper node with this
patch, right? So I don't think it is what you want.

thanks,

greg k-h
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/