Re: [PATCH/RFC] SPI: async message handing library update

From: Vitaly Wool
Date: Wed Dec 21 2005 - 08:15:21 EST


David,

if (t->len) {
/* FIXME if bitbang->use_dma, dma_map_single()
* before the transfer, and dma_unmap_single()
* afterwards, for either or both buffers...
*/


please *please* *_please_*!!! don't do it! :)
Let the controller driver do it *only in case it's not working in PIO!*

Vitaly
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/