Re: [RFC][PATCH 1/6] RTC subsystem, class

From: Alessandro Zummo
Date: Wed Dec 21 2005 - 04:33:08 EST


On Tue, 20 Dec 2005 17:50:12 -0800
Mitchell Blank Jr <mitch@xxxxxxxxxx> wrote:

> > > exporting static symbols is pretty wrong. Exporting tables is pretty
> > > bad style aswell.
> >
> > Tables like this one are often used in rtc drivers. What
> > can I use instead?
>
> Why not just provide a macro in a .h file? Something like:
>
> /* Days in month -- month is in the range (0..11), no leap year */
> #define rtc_days_in_month(mon) (28 + ((0xEEFBB3 >> ((mon) * 2)) & 3))

I just noticed i was exporting a similar functions, so
the table export can be removed.

--

Best regards,

Alessandro Zummo,
Tower Technologies - Turin, Italy

http://www.towertech.it

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/