Re: [patch 05/15] Generic Mutex Subsystem, mutex-core.patch

[Ingo Molnar]

* Steven Rostedt <rostedt@xxxxxxxxxxx> wrote:

> The unlikely below is only for the non MUTEX_LOCKLESS_FASTPATH case.
> Maybe have a define for the unlikely?
> 
> #ifdef MUTEX_LOCKLESS_FASTPATH
> #  define UNLIKELY_SLOW(x) x
> #else
> #  define UNLIKELY_SLOW(x) unlikely(x)
> #endif

> > +       if (unlikely(!list_empty(&lock->wait_list)))
> > +               __mutex_wakeup_waiter(lock __IP__);

i'll rather eliminate the unlikely().

	Ingo
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/