Re: Linux 2.6.15-rc3 - VIDEO_BT848_DVB config

From: Michael Krufky
Date: Tue Nov 29 2005 - 08:06:29 EST


Eyal Lebedinsky wrote:

Linus Torvalds wrote:


I just pushed 2.6.15-rc3 out there, and here are both the shortlog and diffstats appended.


A config issue? It says 'choose M' which is not offered. Maybe it is just
an option for the bt8xx driver, which itself can be built as a module
(CONFIG_VIDEO_BT848)?


DVB/ATSC Support for bt878 based TV cards (VIDEO_BT848_DVB) [N/y/?] (NEW) ?

This adds support for DVB/ATSC cards based on the BT878 chip.

To compile this driver as a module, choose M here: the
module will be called dvb-bt8xx.

No -- It's a typo. CONFIG_VIDEO_BT848_DVB is just an option to CONFIG_VIDEO_BT848. It is a boolean option, and when chosen, Kconfig SELECT's CONFIG_DVB_BT8XX, and that's the actual menu item that builds the module.

The option is set as bool, so that if it's dependencies are set as modules, dvb-bt8xx will also build as a module. If, however, the dependencies are set to build in-kernel, then dvb-bt8xx will do so as well.

Consider this menu item a symbolic link to CONFIG_DVB_BT8XX -- it was the only way to add this as a submenu option to VIDEO_BT848, without removing the reference in the DVB submenu.

Anyhow, this patch removes the incorrect info:

Signed-off-by: Michael Krufky <mkrufky@xxxxxxx>

drivers/media/video/Kconfig | 3 ---
1 file changed, 3 deletions(-)

--- linux-2.6.15-rc3.orig/drivers/media/video/Kconfig 2005-11-29 01:21:42.000000000 -0500
+++ linux-2.6.15-rc3/drivers/media/video/Kconfig 2005-11-29 08:01:39.000000000 -0500
@@ -32,9 +32,6 @@
---help---
This adds support for DVB/ATSC cards based on the BT878 chip.

- To compile this driver as a module, choose M here: the
- module will be called dvb-bt8xx.
-
config VIDEO_SAA6588
tristate "SAA6588 Radio Chip RDS decoder support on BT848 cards"
depends on VIDEO_DEV && I2C && VIDEO_BT848