Re: [2.6 patch] drivers/usb/misc/sisusbvga/sisusb.c: remove deadcode

From: Thomas Winischhofer
Date: Tue Nov 29 2005 - 05:38:05 EST


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Greg KH wrote:
> On Wed, Nov 23, 2005 at 09:31:50PM +0100, Adrian Bunk wrote:
>
>>On Wed, Nov 23, 2005 at 11:02:37AM -0800, Greg KH wrote:
>>
>>>On Mon, Nov 21, 2005 at 12:22:39AM +0100, Adrian Bunk wrote:
>>>
>>>>The Coverity checker found this obviously dead code.
>>>
>>>I think the checker is wrong, this does not look correct to me.
>>
>>Why?
>>
>>Due to the while(length), length can't be 0 at the switch.
>
>
> Doh, ok, nevermind. Care to resend this?


Took me also a few seconds to realize that the tool is correct. Nice stuff.

Thomas

- --
Thomas Winischhofer
Vienna/Austria
thomas AT winischhofer DOT net *** http://www.winischhofer.net

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.2 (GNU/Linux)
Comment: Using GnuPG with Thunderbird - http://enigmail.mozdev.org

iD8DBQFDjCx8zydIRAktyUcRAi8NAKCA96Bt9ibOIRGQWhSUy6qnd5QxYwCeLtHE
VvGqTMgnn476dnm/PYKBSM8=
=3eHZ
-----END PGP SIGNATURE-----
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/