Re: [RFC] Updates to sysfs_create_subdir()

From: Kyle Moffett
Date: Mon Nov 28 2005 - 20:11:34 EST


On Nov 28, 2005, at 15:49, Greg KH wrote:
On Wed, Nov 23, 2005 at 01:56:29PM -0800, Patrick Mochel wrote:
The patch below addresses this issue by parsing the subdirectory name and creating any parent directories delineated by a '/'.

Generally I never liked parsing stuff like this in the kernel (proc and devfs both do this). That being said, I do see the need to make subdirs like this easier.

But what about cleanups? If I create an attribute group "foo/baz/ x/" and then remove it, will the subdirectories get cleaned up too? What about if I had created a group "foo/baz/y/" after the "x" one? Or just "foo/baz"?

If the kernel gets this, then udev needs to allow attributes with more generic paths too. It would be nice if I could use this [Pulled from the sample udev output halfway down this page: http:// www.reactivated.net/writing_udev_rules.html#identify-sysfs].

BUS="scsi", SYSFS{../../../manufacturer}="Tekom Technologies, Inc", NAME="my_camera"

Frequently the attributes one wants to filter by are spread out through the tree, especially when they've been subdivided for clarity as people seem to want to do.

Cheers,
Kyle Moffett

--
I lost interest in "blade servers" when I found they didn't throw knives at people who weren't supposed to be in your machine room.
-- Anthony de Boer


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/