Re: [PATCH 1/4] stack overflow safe kdump (i386) - safe_smp_processor_id

From: Andi Kleen
Date: Mon Nov 28 2005 - 13:39:22 EST


Fernando Luis Vazquez Cao <fernando@xxxxxxxxxxxxxxxxx> writes:
>
> To circumvent this problem I suggest implementing
> "safe_smp_processor_id()" (it already exists on x86_64) for i386 and
> IA64 and use it as a replacement to smp_processor_id in the reboot path
> to the dump capture kernel. This is a possible implementation for i386.

It's not fully safe, because a SMP kernel might run on a 32bit
system without APIC. Then hard_smp_processor_id() would fault.
(this cannot happen on x86-64)

You probably need to check one of the globals set by apic.c
when its disabled.

-Andi
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/