Re: [PATCH 25/39] NLKD/x86-64 - core

From: Andi Kleen
Date: Thu Nov 10 2005 - 09:03:33 EST


On Wednesday 09 November 2005 15:21, Jan Beulich wrote:
> The core x86-64 NLKD additions.

I probably won't merge that unless the full NLKD somehow manages to get
into mainline. Shouldn't be that hard to maintain out of tree or even
build the debugger in a fully separate directory.

My general suggestion would be to move away from using your own
defines for all the architecture state (MSRs etc) but instead use
the ones from the Linux headers instead which should be largely
equivalent (if there are some missing we can probably add them)
And getting of that Intel style assembly would be good too.

I would move the asm-offset bits into a separate file, perhaps run from
the NLKD Makefile, that should reduce later merging pain.

-Andi
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/