Re: [PATCH resubmit] do_mount: reduce stack consumption

From: Andrew Morton
Date: Fri Nov 04 2005 - 13:38:27 EST


Arjan van de Ven <arjanv@xxxxxxxxxx> wrote:
>
> On Fri, Nov 04, 2005 at 09:42:12AM -0800, Andrew Morton wrote:
> > Andreas Herrmann <AHERRMAN@xxxxxxxxxx> wrote:
> > >
> > > Obviously you missed the point that (depending on the compiler version,
> > > options etc.) do_move_mount() and do_add_mount() can be inlined.
> >
> > I think we found a way of preventing the 3.x compiler from doing that. Arjan,
> > do you recall where we ended up with that problem?
>
> it was mostly caused by -funit-at-a-time that caused 3.x to go haywire. You
> need to turn that off in general.

In that case, does s390 still have a problem that we need to be solving here?

(s390 doesn't implement CONFIG_DEBUG_STACK_USAGE. Suggest you do so, then
stick a dump_stack() into do_exit()).

(dm is still doing very risky things though)
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/