Re: [0/3] Fix timer bugs in neighbour cache

From: Arnaldo Carvalho de Melo
Date: Sun Oct 23 2005 - 11:17:04 EST


Em Sun, Oct 23, 2005 at 05:30:21PM +1000, Herbert Xu escreveu:
> Reuben Farrelly <reuben-lkml@xxxxxxxx> wrote:
> >
> > Oct 17 18:49:40 tornado kernel: NEIGH: BUG, double timer add, state is 1
> > Oct 17 18:51:04 tornado last message repeated 3 times
> > Oct 17 18:52:05 tornado last message repeated 5 times
> > Oct 17 18:52:11 tornado last message repeated 2 times
>
> Excellent. Looks like we actually caught something. Pity we don't have
> a stack trace which means that there might be more bugs.
>
> Anyway, here are three patches which should fix this. This should go
> into 2.6.14.
>
> Arnaldo, you can pull them from
>
> master.kernel.org:/pub/scm/linux/kernel/git/herbert/net-2.6.git

Thanks, pulled.

I guess at some point I'll try to make the neighbour code more like the
sock one where we have things like sk_reset_timer and sk_stop_timer for
this purpose.

- Arnaldo
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/