Re: [PATCH 4/4] Swap migration V3: sys_migrate_pages interface

[Christoph Lameter]

On Fri, 21 Oct 2005, Paul Jackson wrote:

>  * Christoph - what is the permissions check on sys_migrate_pages()?
>    It would seem inappropriate for 'guest' to be able to move the
>    memory of 'root'.

The check is missing. 

Maybe we could add:

 if (!capable(CAP_SYS_RESOURCE))
                return -EPERM;

Then we may also decide that root can move any process anywhere and drop 
the retrieval of the mems_allowed from the other task.

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/