Re: [PATCH 4/4] Swap migration V3: sys_migrate_pages interface

[KAMEZAWA Hiroyuki]

Simon Derr wrote:
> > > Christoph Lameter wrote:
> > > > > > +	/* Is the user allowed to access the target nodes? */
> > > > > > +	if (!nodes_subset(new, cpuset_mems_allowed(task)))
> > > > > > +		return -EPERM;
> > > > > > +
> > >
> > > > How about this ?
> > > > +cpuset_update_task_mems_allowed(task, new);    (this isn't implemented
> > > > now
> >
> > *new* is already guaranteed to be the subset of current mem_allowed.
> > Is this violate the permission ?
>
>
> Oh, I misunderstood your mail.
> I thought you wanted to automatically add extra nodes to the cpuset,
> but you actually want to do just the opposite, i.e restrict the nodemask 
> for this task to the one passed to sys_migrate_pages(). Is that right ?
yes.
Anyway, we should modify task's mem_allowed before the first page fault.

-- Kame


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/