Re: [PATCH] scsi_error thread exits in TASK_INTERRUPTIBLE state.

From: Ingo Molnar
Date: Wed Oct 19 2005 - 06:57:16 EST



* Steven Rostedt <rostedt@xxxxxxxxxxx> wrote:

> On Wed, 19 Oct 2005, Christoph Hellwig wrote:
>
> > > + /*
> > > + * There's a good chance that the loop will exit in the
> > > + * TASK_INTERRUPTIBLE state.
> > > + */
> > > + __set_current_state(TASK_RUNNING);
> >
> > no need to comment the obvious.
>
> So, should I resend the patch without the comment?

i guess so. OTOH, if it was so obvious, why did it stay unfixed for so
long ;-)

Ingo
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/