Re: 2.6.14-rc4-rt7

From: Ingo Molnar
Date: Wed Oct 19 2005 - 06:20:30 EST



* William Weston <weston@xxxxxxxxxxxx> wrote:

> Hello,
>
> Getting up to speed on the latest -rt changes again. Just happened to
> notice this warning with -rt8 and -rt9:
>
> kernel/ktimers.c: In function `check_ktimer_signal':
> kernel/ktimers.c:1209: warning: passing argument 1 of
> `unlock_ktimer_base' from incompatible pointer type
>
> And the obvious fix:
>
> --- linux/kernel/ktimers.c.orig 2005-10-18 14:10:48.000000000 -0700
> +++ linux/kernel/ktimers.c 2005-10-18 14:24:43.000000000 -0700
> @@ -1206,7 +1206,7 @@
> struct ktimer_base *base = lock_ktimer_base(timer, &flags);
> ktime_t now = base->get_time();
>
> - unlock_ktimer_base(base, &flags);
> + unlock_ktimer_base(timer, &flags);
>

indeed - and this could explain some of the lockups reported. I've
uploaded -rt10 with your fix included.

Ingo
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/