Re: [PATCH] ppc64: Thermal control for SMU based machines

From: linas
Date: Tue Oct 18 2005 - 15:57:32 EST


On Wed, Oct 12, 2005 at 10:24:51AM +1000, Benjamin Herrenschmidt was heard to remark:
> > > +#define BUILD_SHOW_FUNC_FIX(name, data) \
> > > +static ssize_t show_##name(struct device *dev, \
> > > + struct device_attribute *attr, \
> > > + char *buf) \
> > > +{ \
>
> Ahh no, the problem here is that stupid emacs is very bad with tab
> and multi-line macros and just turns the whole thing into shit, so
> I used spaces. Sorry, I'm not an emacs guru and don't know how to
> work around that ...

Anyone who has tabstops set to 3 instead of 8 will see broken-ness for
macros like this no matter what. Suggest that the right policy is to use
only spaces, and neve tabs, inside of macros.

--linas
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/