Re: ohci1394 unhandled interrupts bug in 2.6.14-rc2

[Stefan Richter]

Jesse Barnes wrote:
> > Jesse, what DMI_PRODUCT_NAME matches your laptop?
>
> I'll have to check when I get home, is the relevant info from the "System 
> Information" section of the dmidecode output?

AFAICT yes. Although I wonder if there is a better suited part of the 
DMI table to look at. From what Rob posted, we could simply match 
{DMI_SYS_VENDOR, "TOSHIBA"} && {DMI_PRODUCT_VERSION, "PS5"} which 
probably catches all Satellite 5xxx's. I hope this isn't too general.

I also wonder how 1394 CardBus cards would react on this patch in 
affected Toshibas...

| +	toshiba = dmi_check_system(extra_init_dmi_table);
| +	if (toshiba) {
| +	        PRINT_G(KERN_INFO, "Toshiba %s detected, enabling extra 
initialization code",
| +			dmi_get_system_info(DMI_PRODUCT_NAME));
| +	        dev->current_state = 4;
| +		pci_read_config_word(dev, PCI_CACHE_LINE_SIZE, &toshiba_pcls);
| +	}
...
|	if (pci_enable_device(dev))
|  		FAIL(-ENXIO, "Failed to enable OHCI hardware");
...
| +	if (toshiba) {
| +	        mdelay(10);
| +	        pci_write_config_word(dev, PCI_CACHE_LINE_SIZE, toshiba_pcls);
| +	        pci_write_config_word(dev, PCI_INTERRUPT_LINE, dev->irq);
| +	        pci_write_config_dword(dev, PCI_BASE_ADDRESS_0, 
pci_resource_start(dev, 0));
| +	        pci_write_config_dword(dev, PCI_BASE_ADDRESS_1, 
pci_resource_start(dev, 1));
| +	}
...
|	pci_set_master(dev);

--
Stefan Richter
-=====-=-=-= =-=- =---=
http://arcgraph.de/sr/
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/