Re: [PATCH 2/2] Convert megaraid to use pci_driver shutdown metho d

[Greg KH]

On Mon, Oct 17, 2005 at 06:10:25PM +0100, Christoph Hellwig wrote:
> On Mon, Oct 17, 2005 at 10:08:55AM -0700, Greg KH wrote:
> > On Mon, Oct 17, 2005 at 02:42:28PM +0100, Christoph Hellwig wrote:
> > > On Mon, Oct 17, 2005 at 09:26:12AM -0400, Kolli, Neela Syam wrote:
> > > > Patch looks good.  Thanks for the patch.
> > > 
> > > another 2.6.14 candidate, without it we'd easily get corruption
> > > on shutdown when the root filesystem is on megaraid.
> > 
> > No, the megaraid shutdown method will be called, only if that member
> > isn't set will the pci shutdown call be made.  So this should be safe
> > today, right?
> 
> If that actually got fixed it's fine indeed.

The code today is:

        /* FIXME, once all of the existing PCI drivers have been fixed to set
         * the pci shutdown function, this test can go away. */
        if (!drv->driver.shutdown)
                drv->driver.shutdown = pci_device_shutdown;

so we should be fine.

thanks,

greg k-h
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/