Re: [PATCH][Fix][Resend] Fix Bug #4959: Page tables corrupted during resume on x86-64 (take 3)

[Siddha, Suresh B]

On Fri, Sep 30, 2005 at 12:01:08AM +0200, Rafael J. Wysocki wrote:
> On Thursday, 29 of September 2005 02:00, Siddha, Suresh B wrote:
> > 
> > My patch as such shouldn't change the behavior of the existing swsup
> > code. I am making only boot_level4_pgt as initdata. But not the 
> > init_level4_pgt.
> 
> Suresh, unfortunately the kernel does not boot with your patch, because

Did you try just only my patch on top of 2.6.14-rc2? You can get that
patch from http://www.x86-64.org/lists/discuss/msg07313.html

> it clears init_level4_pgt.

what is wrong with zapping low mappings? Looks like someother change
you are trying assumes that low mappings are always present in init_level4_pgt,
which is wrong..

> +++ linux-2.6.14-rc2-git7/arch/x86_64/mm/init.c	2005-09-29 22:13:55.000000000 +0200
> @@ -313,7 +313,7 @@
>  void __cpuinit zap_low_mappings(int cpu)
>  {
>  	if (cpu == 0) {
> -		pgd_t *pgd = pgd_offset_k(0UL);
> +		pgd_t *pgd = boot_level4_pgt;
>  		pgd_clear(pgd);

Don't do this. Its wrong.

Please send me your patch that you are having problems with. I can take 
a look at it.

thanks,
suresh
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/