Re: Linux SATA S.M.A.R.T. and SLEEP? -- was [PATCH libata-dev-2.6:passthru]passthru fixes

[Mark Lord]

John W. Linville wrote:
> You probably want this patch as well, at least the first hunk.
> It fixes a potential memory leak that could cause lock-ups when using
> hdparm or smartctl/smartd.
>
> John
> ---
> Fix a few problems seen with the passthru branch:
>
> - leaked scsi_request on buffer allocate failure
> - passthru sense routines were refering to tf->command
>   which is not read in tf_read, instead use drv_stat for
>   status register.
> - passthru sense passed back to user on ata_task_ioctl
>
> Patch is against the current libata-dev passthru branch.
>
> Signed-off-by: Jeff Raubitschek <jhr@xxxxxxxxxx>
...

When I tried that patch recently, smartctl stopped working.
Reverted.  Works again.

??
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/