Re: [PATCH 1/3] CPUMETER: add cpumeter framework to the CPUSETS

[Hirokazu Takahashi]

Hello,

> > It could have come a long way since then, but this code looks
> > much neater than the code I reviewed.
> 
> I'm glad to hear that!  But the cpu resource controller has
> some problems, for example:

These are issues to be improved.

> - The controller only controls the time_slice value and doesn't
>   care the balance of cpus (the controller leaves balancing to 
>   the existing balancing code in the scheduler).  So far I don't
>   have any good idea to solve this.

Is there any problem to enhance load_balance()? Applying some weight
to each process, it would be used for calculating load of each runqueue.

> - The controller holds a spinlock once per 1 second.  I don't
>   know this is permissive or not, but the current scheduler
>   doesn't hold any spinlocks normally, so...

I think each runqueue has its own spinlock, which is held quite often.


Thanks,
Hirokazu Takahashi.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/