Re: [PATCH 2.6.14-rc2] fix incorrect mm->hiwater_vm and mm->hiwater_rss

[Jay Lan]

Christoph Lameter wrote:
> On Tue, 27 Sep 2005, Jay Lan wrote:
>
>
> > Just looked at the __vm_stat_account() code. It is enclosed inside
> > #ifdef CONFIG_PROC_FS.
> >
> > If that is necessary, i can not put hiwater_vm update code in there. The
> > system accounting code should not be dependent on a config flag that has
> > nothing to do with system accounting.
>
>
> I doubt you can do accounting without having /proc. Dont you need to 
> read/write files in /proc? Can we make accounting dependent on /proc?

Right, system accounting code (BSD_PROCESS_ACCT) does not depend on
/proc.

In my opinion, those "everyone should say Y here" config flags should
not be config flags at all. Since it is a flag, i should not put
sys accounting code in there.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/