Re: [PATCH 1/3] block cleanups: Fix iosched module refcount leak

From: Jens Axboe
Date: Tue Sep 27 2005 - 17:41:15 EST


On Tue, Sep 27 2005, Nate Diller wrote:
> If the requested I/O scheduler is already in place, elevator_switch simply
> leaves the queue alone, and returns. However, it forgets to call
> elevator_put, so
>
> 'echo [current_sched] > /sys/block/[dev]/queue/scheduler'
>
> will leak a reference, causing the current_sched module to be permanently
> pinned in memory.
>
> This patchset is against 2.6.14-rc2-mm1, but should apply to anything
> recent.

Thanks, looks good.

Signed-off-by: Jens Axboe <axboe@xxxxxxx>

--
Jens Axboe

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/