Re: [PATCH 2.6.14-rc2] aoe [1/2]: explicitly set minimum packetlength to ETH_ZLEN

From: Ed L Cashin
Date: Tue Sep 27 2005 - 16:48:31 EST


"David S. Miller" <davem@xxxxxxxxxxxxx> writes:

> From: Ed L Cashin <ecashin@xxxxxxxxxx>
> Date: Mon, 26 Sep 2005 18:28:39 -0400
>
>> No, it looks like alloc_skb just kmallocs the data, so I'd need to
>> follow up with something like this:
>
> You should explicitly initialize the data areas of the SKB as you
> "push" and "put" to allocate space in the data buffer, not right
> after alloc_skb() and before you've allocate any space.

Sure, we can do that. I will resend these patches.

--
Ed L Cashin <ecashin@xxxxxxxxxx>

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/