Re: [Patch] eliminate CLONE_* duplications

From: Roman Zippel
Date: Tue Sep 27 2005 - 12:04:35 EST


Hi,

On Tue, 27 Sep 2005, Herbert Poetzl wrote:

> > "logically organized" mainly means reducing dependencies by organizing
> > them by their logical dependencies.
>
> did you consider that separating out the clone
> stuff might be that basis for reducing dependencies?

Not in this form, all users of this flag need other definitions from
sched.h.

> > The hardcoded defines actually do need fixing, frv is especially bad,
> > as it even has hardcoded structure offsets.
>
> so instead of fixing the issue properly, we
> 'mend' it by adding new code to */asm-offsets.c

Using asm-offsets.c _is_ a proper solution.

> > sched.h is especially challenging due to dependencies between headers
> > under asm and linux. It's not just splitting sched.h, it also requires
> > analyzing its dependencies.
>
> which you obviously think is nothing I can do
> 'properly' ...

I don't know, but I know that it does require a large amount of experience
in this area.

bye, Roman
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/