Re: [PATCH] umask in POSIX message queues

[Linus Torvalds]

On Mon, 26 Sep 2005, Krzysztof Benedyczak wrote:
> 
> All kernels (form 2.6.6) ignore umask when creating new queues via
> mq_open (when creating with open() on mqueue fs it is ok of course).
> According to specification this a bug. The following trivial patch fixes
> this. It should apply cleanly to any current kernel. Please apply.

As far as I can tell, the VFS layer should have done this for us already, 
with code like

		...
                if (!IS_POSIXACL(dir->d_inode))
                        mode &= ~current->fs->umask;
                error = vfs_create(dir->d_inode, path.dentry, mode, nd);
		...

in fs/namei.c (open_namei()).

Which path did you come through that didn't do this? That would be the
real bug, I suspect..

		Linus
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/