Re: [PATCH 2/2] HPET: make frequency calculations 32 bit safe

From: Clemens Ladisch
Date: Mon Sep 26 2005 - 02:30:43 EST


Karsten Wiese wrote:
> > --- linux-2.6.13.orig/drivers/char/hpet.c 2005-09-22 11:10:01.000000000 +0200
> > +++ linux-2.6.13/drivers/char/hpet.c 2005-09-22 12:08:48.000000000 +0200
> > ...
> > - unsigned long hp_period;
> > + unsigned long long hp_tick_freq;
>
> An 'unsigned long' is enough.
> Are we expecting hpets stepping at more than 4GHz?

The HPET specification allows up to 10 GHz.

> They are called 'legacy' in some docs already ;-)

Do these docs mention a non-legacy alternative?

> Here the via8237's hpet runs at ~14MHz.

AFAIK all current implementations still use the good ol' 14.138180MHz
timer.


Regards,
Clemens

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/