Re: SATA suspend-to-ram patch - merge?

From: Pavel Machek
Date: Sat Sep 24 2005 - 04:58:29 EST


Hi!

> >Is Jens' patch still relevant? If so, should it be rediffed and
> >merged
> >into mainline? It doesn't seem to cause any weird side-effects.
> >
> >More importantly, I would be inclined to properly rediff Jens' patch
> >and
> >merge it into Debian 2.6.12 kernel sources if there aren't any such
> >side-effects, since it benefits everyone using SATA and
> >suspend-to-ram
> >(that is, users of relatively modern laptops.)
>
> Jens' patch is technical correct for SATA, but really we want to do
> more stuff at the SCSI layer (see James Bottomley's response to Jens'
> patch).
>
> Unfortunately, this also implies that we have to figure out which
> SCSI devices are available to be power-managed, and which SCSI
> devices are on a shared bus that should never be suspended.

I think that shared buses are rare enough to be safely ignored.
We could simply say "never ever suspend machine with some
disks on shared bus".

Pavel
--
64 bytes from 195.113.31.123: icmp_seq=28 ttl=51 time=448769.1 ms

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/