Re: [PATCH 1/7] spufs: The SPU file system

From: Geoff Levand
Date: Mon Aug 29 2005 - 13:11:30 EST


Arnd Bergmann wrote:
> On Freedag 26 August 2005 10:17, Pekka Enberg wrote:
>
>>I am confused. The code is architecture specific and does device I/O. Why do
>>you want to put this in fs/ and not drivers/?
>
>
> I never really thought of it as a device driver but rather an architecture
> extension, so it started out in arch/ppc64/kernel. Since most of the code
> is interacting with VFS, it is now in fs/spufs. I don't really care about
> the location, but I among the possible places to put the code (with the
> unified arch/powerpc tree), I'd suggest (best first)
>
> 1) arch/powerpc/platforms/cell
> 2) arch/powerpc/spe
> 3) fs/spufs
> 4) drivers/spe
>
> 1) would be the place where I want to have the low-level code
> (currently arch/ppc64/kernel/spu_base.c) anyway, so it makes
> sense to have everything in there that I maintain.
> 2) might work better if we at a later point have multiple platform
> types in arch/powerpc that use SPEs, e.g if we want to keep
> Playstation code separate from generic Cell.
>

I think putting it in 'arch/powerpc/platforms/cell' is fine for now. We'll
be better able to judge if we need to and how to split off platform specifics
when we have code for more cell platforms.

-Geoff

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/