Re: [PATCH] blk queue io tracing support

From: Jens Axboe
Date: Wed Aug 24 2005 - 02:08:56 EST


On Wed, Aug 24 2005, Nathan Scott wrote:
> Hi Jens,
>
> On Tue, Aug 23, 2005 at 02:32:36PM +0200, Jens Axboe wrote:
> > ...
> > + t.pid = current->pid;
> > ...
> > +/*
> > + * The trace itself
> > + */
> > +struct blk_io_trace {
> > + u32 magic; /* MAGIC << 8 | version */
> > + u32 sequence; /* event number */
> > + u64 time; /* in microseconds */
> > + u64 sector; /* disk offset */
> > + u32 bytes; /* transfer length */
> > + u32 action; /* what happened */
> > + u16 pid; /* who did it */
>
> Also, this field (pid) should probably be a u32.

Ah yes, thanks!

--
Jens Axboe

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/