Re: some missing spin_unlocks

From: David S. Miller
Date: Tue Aug 23 2005 - 12:47:10 EST


From: Arjan van de Ven <arjan@xxxxxxxxxxxxx>
Subject: Re: some missing spin_unlocks
Date: Tue, 23 Aug 2005 19:40:06 +0200

> On Tue, 2005-08-23 at 10:30 -0700, David S. Miller wrote:
> > From: Arjan van de Ven <arjan@xxxxxxxxxxxxx>
> > Date: Tue, 23 Aug 2005 18:54:03 +0200
> >
> > > does it matter? can ANYTHING be spinning on the lock? if not .. can we
> > > just let the lock go poof and not unlock it...
> >
> > I believe socket lookup can, otherwise the code is OK as-is.
>
> lookup while the object is in progress of being destroyed sounds really
> bad though....

This happens all the time with TCP sockets, for example.
When we're trying to kill off a socket which is in time
wait state, the receive path can find it, grab a reference,
and process a packet against it right as we're trying to
kill it off.

This is completely normal.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/