Re: [PATCH] Permissions don't stick on ConfigFS attributes

From: Daniel Phillips
Date: Mon Aug 22 2005 - 14:44:14 EST


On Monday 22 August 2005 00:49, Eric W. Biederman wrote:
> I am confused. I am beginning to see shades of the devfs problems coming
> up again. sysfs is built to be world readable by everyone who has it
> mounted in their namespace. Writable files in sysfs I have never
> understood.

Sysfs is not like devfs by nature, it is more like procfs. It exposes
properties of a device, not the device itself. It makes perfect sense that
some of the properties should be writeable.

> Given that we now have files which do not conform to one uniform
> policy for everyone is there any reason why we do not want to allocate
> a character device major number for all config values and dynamically
> allocate a minor number for each config value? Giving each config
> value its own unique entry under /dev.

/dev is already busy enough without adding masses of entries that are not
devices. I don't see that this would simplify the internal implementation
either, the opposite actually. The user certainly will not have any use for
temporary device numbers in this context.

On the other hand, it is clunky to force an application to go through the same
parse/format interface as the user just to get/set a simple integer. Perhaps
sysfs needs to be taught how to ioctl these properties. I see exposing
property names and operating on them as orthogonal issues that are currently
joined at the hip in an unnatural, but fixable way.

> Device nodes for each writable config value trivially handles
> persistence and user policy and should be easy to implement in the
> kernel. We already have a policy engine in userspace, udev to handle
> all of the chaos.
>
> Why do we need another mechanism?

We need the mechanism that exposes subsystem instance properties as they
appear and disappear with changing configuration. This is a new mechanism
anyway, so implementing it using device nodes does not save anything, it only
introduces a new requirement to allocate device numbers.

> Are device nodes out of fashion these days?

They are, at least for putting things in /dev that are not actual hardware.

Regards,

Daniel
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/