Re: s390 build fix.

From: Al Viro
Date: Sun Aug 21 2005 - 00:09:36 EST


On Sun, Aug 21, 2005 at 12:38:39AM -0400, Dave Jones wrote:
> {standard input}: Assembler messages:
> {standard input}:397: Error: symbol `.Litfits' is already defined
> {standard input}:585: Error: symbol `.Litfits' is already defined
>
> Newer gcc's inline this it seems, which blows up.

Eeek... Much easier (and already sent to Linus):

diff -urN RC13-rc6-git2-arm-float/arch/s390/kernel/cpcmd.c RC13-rc6-git2-s390/arch/s390/kernel/cpcmd.c
--- RC13-rc6-git2-arm-float/arch/s390/kernel/cpcmd.c 2005-08-10 10:37:46.000000000 -0400
+++ RC13-rc6-git2-s390/arch/s390/kernel/cpcmd.c 2005-08-10 20:38:56.000000000 -0400
@@ -46,9 +46,9 @@
"lra 3,0(%4)\n"
"lr 5,%5\n"
"diag 2,4,0x8\n"
- "brc 8, .Litfits\n"
+ "brc 8, 1f\n"
"ar 5, %5\n"
- ".Litfits: \n"
+ "1: \n"
"lr %0,4\n"
"lr %1,5\n"
: "=d" (return_code), "=d" (return_len)
@@ -64,9 +64,9 @@
"sam31\n"
"diag 2,4,0x8\n"
"sam64\n"
- "brc 8, .Litfits\n"
+ "brc 8, 1f\n"
"agr 5, %5\n"
- ".Litfits: \n"
+ "1: \n"
"lgr %0,4\n"
"lgr %1,5\n"
: "=d" (return_code), "=d" (return_len)
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/