Re: [PATCH] fix dst_entry leak in icmp_push_reply()

[Ollie Wild]

Patrick McHardy wrote:

> Ollie Wild wrote:
>
> > If the ip_append_data() call in icmp_push_reply() fails, 
> > ip_flush_pending_frames() needs to be called.  Otherwise, ip_rt_put() 
> > is never called on inet_sk(icmp_socket->sk)->cork.rt, which prevents 
> > the route (and net_device) from ever being freed.
>
>
> Your patch doesn't fit your description, the else-condition you're
> adding triggers when the queue is empty, so what is the point?

Since we're only calling ip_append_data() once here, the two conditions 
are identical.

Ollie
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/