Re: [PATCH] mmc: Multi-sector writes

From: Pierre Ossman
Date: Thu Aug 18 2005 - 00:48:35 EST


Andrew Morton wrote:

>The fact that this is enabled under the experimental
>CONFIG_MMC_BULKTRANSFER seems unfortunate. I mean, if the code works OK
>then we should just enable it unconditionally, no?
>
>
>

It was made this way to make Russell more open to it. I have since not
recieved any more comments from him so I figured I could pass it by you
instead to get more wide spread testing. The long term goal was removing
the config and having it on all the time.

>I'm thinking that it would be better to not have the config option there
>and then re-add it late in the 2.6.14 cycle if someone reports problems
>which cannot be fixed. Or at least make it default to 'y' so we get more
>testing coverage, then remove the config option later. Or something.
>
>Thoughts?
>
>

Removing it would be preferable by me. All that #ifdef tends to clutter
up the code. After som initial problem with a buggy card everything has
worked flawlesly.

Rgds
Pierre

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/