Re: [PATCH 4/14] i386 / Clean up asm and volatile keywords in desc

From: Chris Wright
Date: Tue Aug 16 2005 - 18:52:29 EST


* Andi Kleen (ak@xxxxxxx) wrote:
> On Wed, Aug 10, 2005 at 09:53:51PM -0700, zach@xxxxxxxxxx wrote:
> > Stop using extra underscores on asm and volatiles, that is just silly.
>
> Actually the volatiles might be still useful. Or if you drop them
> at least add memory clobbers.

They are still there, just the underscores on both asm and volatile got
pulled.

> I had sometimes bugs on x86-64
> with the compiler moving such assembly statements with invisible
> side effects around too aggressively and causing weird problems.
>
> Agreed on the underscores, I hate them too :)

Heh, same here ;-)

thanks,
-chris
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/