Re: [PATCH 3/4] cciss 2.4: adds 2 ioctls for ia64 based systems

[Christoph Hellwig]

On Mon, Aug 15, 2005 at 04:32:53PM -0500, James Bottomley wrote:
> On Mon, 2005-08-15 at 16:22 -0500, mikem wrote:
> > +#ifdef CONFIG_IA64
> > +        case BLKGETLASTSECT:
> > +        case BLKSETLASTSECT:
> > +#endif
> >  		return blk_ioctl(inode->i_rdev, cmd, arg);
> 
> What makes these two ioctls IA64 specific?  I think they're completely
> general in 2.4, so there's no need for the #ifdef.

They don't exist in 2.4 mainline.  The ia64 patch and then many
distributions introduced it because the EFI partitions spec contains
some braindamage that requries accessing the last sector.  In 2.6 the
block device nodes can do that, so the ioctls aren't needed either.

In short this patch should not go into mainline 2.4, it doesn't support
ia64 anyway and if it did it wouldn't compile because the ioctls aren't
defined.

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/