Re: [PATCH 2.6.13-rc6] PCI/libata INTx cleanup

[Greg KH]

On Mon, Aug 15, 2005 at 03:08:47PM -0400, Brett Russ wrote:
> Greg KH wrote:
> >On Fri, Aug 12, 2005 at 06:43:03PM -0400, Brett Russ wrote:
> >
> >>Simple cleanup to eliminate X copies of the pci_enable_intx() function
> >>in libata.  Moved ahci.c's pci_intx() to pci.c and use it throughout
> >>libata and msi.c.
> >>
> >>Signed-off-by: Brett Russ <russb@xxxxxxx>
> >
> >
> >It would have been nice if you had built this code :(
> >
> >Hint, get rid of all TRUE and FALSE usages in your patch.  Care to try
> >again?
> >
> >thanks,
> >
> >greg k-h
> 
> 
> Hmm, I did build it before submitting, saw not even a warning.  So I 
> just rebuilt it again to verify, and same thing.  Why would my tree work 
> and not yours?  config file?

You don't have MSI enabled in yours :(

thanks,

greg k-h
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/