Re: [PATCH] configurable debug info from radeonfb old driver

[Andrew Morton]

Michael Iatrou <m.iatrou@xxxxxxxxxxx> wrote:
>
> Hi,
> 
> Currently, radeonfb old driver always prints debugging informations. This 
> patch makes debug info reporting configurable.
>  
> 
> diff -urN linux-2.6.13-rc6/drivers/video/Kconfig linux-2.6.13-rc6.new/drivers/video/Kconfig
> --- linux-2.6.13-rc6/drivers/video/Kconfig      2005-08-14 00:48:34.000000000 +0300
> +++ linux-2.6.13-rc6.new/drivers/video/Kconfig  2005-08-14 00:54:10.000000000 +0300
> @@ -936,6 +936,15 @@
>           There is a product page at
>           <http://www.ati.com/na/pages/products/pc/radeon32/index.html>.
> 
> +config FB_RADEON_OLD_DEBUG
> +    bool "Enable debug output from Old Radeon driver"
> +    depends on FB_RADEON_OLD
> +    default n
> +    help
> +      Say Y here if you want the Radeon driver to output all sorts
> +      of debugging informations to provide to the maintainer when
> +      something goes wrong.
> +
>  config FB_RADEON
>         tristate "ATI Radeon display support"
>         depends on FB && PCI
> diff -urN linux-2.6.13-rc6/drivers/video/radeonfb.c linux-2.6.13-rc6.new/drivers/video/radeonfb.c
> --- linux-2.6.13-rc6/drivers/video/radeonfb.c   2005-06-19 14:49:29.000000000 +0300
> +++ linux-2.6.13-rc6.new/drivers/video/radeonfb.c       2005-08-14 00:55:16.000000000 +0300
> @@ -80,7 +80,11 @@
>  #include <video/radeon.h>
>  #include <linux/radeonfb.h>
> 
> -#define DEBUG  1
> +#ifdef CONFIG_FB_RADEON_OLD_DEBUG
> +#define DEBUG       1
> +#else
> +#define DEBUG       0
> +#endif
> 
>  #if DEBUG
>  #define RTRACE         printk

That's probably a bit fancier than we really need.  How about we just set
DEBUG to zero?

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/