Re: [PATCH] Convert sigaction to act like other unices

From: Andi Kleen
Date: Sat Aug 13 2005 - 16:31:58 EST


On Sat, Aug 13, 2005 at 10:00:14AM -0400, Steven Rostedt wrote:
> On Sat, 2005-08-13 at 14:39 +0200, Andi Kleen wrote:
> > On Fri, Aug 12, 2005 at 10:40:02PM -0400, Steven Rostedt wroqte:
> > > Here's a patch that converts all architectures to behave like other unix
> > > boxes signal handling. It's funny that I didn't need to change the m68k
> > > architecture, since it was the only one that already behaves this way!
> > > (the m68knommu does not!)
> >
> > <rest snipped which also wasn't better>
> >
> > This is not a description of what you changed. A patch entry has to
> > start with a rationale and then a description of the change.
>
> Sorry, I forgot that not all were in on the thread. (duh, I added a
> bunch of others, I guess I wasn't thinking clearly).

I actually read the thread, but patches with useless descriptions
like your previous one cannot be applied in general because you cannot expect
that people later looking at the <VCS system of the week> logs
know about some obscure thread months or years before. Or rather
the person who applied it would need to write a better description
on his own, which is not their job.

My general feeling about the change is that it risks breaking programs
and doesn't seem to have any compelling advantages,
so unless there is a bug demonstrated I wouldn't apply it.

-Andi

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/