Re: [PATCH] Fix mmap_kmem (was: [question] What's the differencebetween /dev/kmem and /dev/mem)

From: Arjan van de Ven
Date: Sat Aug 13 2005 - 13:19:20 EST


On Sat, 2005-08-13 at 10:37 -0700, Linus Torvalds wrote:
>
> On Sat, 13 Aug 2005, Arjan van de Ven wrote:
> >
> > attached is the same patch but now with Steven's change made as well
>
> Actually, the more I looked at that mmap_kmem() function, the less I liked
> it. Let's get that sucker fixed better first. It's still not wonderful,
> but at least now it tries to verify the whole _range_ of the mapping.

actually if that is your goal this just isn't enough... assume the
situation of a 1 page "forbidden gap", if you mmap 3 pages with the gap
in the middle.... then the code you send still doesn't cope. At which
point... it gets messy...

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/