Re: [PATCH 2.6.12.3] PCI/libata INTx cleanup

From: Jeff Garzik
Date: Fri Aug 12 2005 - 16:30:56 EST


Brett Russ wrote:
Jeff Garzik wrote:

Though there is nothing wrong with this patch, I would prefer a single function, pci_intx(), as found in drivers/scsi/ahci.c.

Sounds like what I did, except for the naming change. I did away with
pci_disable_intx() and changed the names. Look ok?


Nope.

<thinks, and checks something> Ahhhhh. You were looking at an older kernel.Nope. Read the implementation I referenced, in ahci.c, from 2.6.13-rc6. It takes a second argument:

static void pci_intx(struct pci_dev *pdev, int enable)

Regards,

Jeff


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/